Skip to content

fix(files): reuse available data for folder tree#58122

Open
susnux wants to merge 1 commit intomasterfrom
fix/folder-tree
Open

fix(files): reuse available data for folder tree#58122
susnux wants to merge 1 commit intomasterfrom
fix/folder-tree

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Feb 5, 2026

Summary

This delays the folder tree generation until the files list was initially loaded,
this allows us to reuse the fetched data for the currently open folder.
Meaning we already know which folders are available under the current folder.

Moreover we also can generate the folder tree to the root (without siblings) which leads to faster initial load.
The other siblings are loaded when the tree was initialized and they are requested by the user.

Checklist

@susnux susnux added this to the Nextcloud 34 milestone Feb 5, 2026
@susnux
Copy link
Contributor Author

susnux commented Feb 5, 2026

/backport to stable33

@susnux susnux force-pushed the chore/update-files branch from dd2417f to 2a07545 Compare February 5, 2026 21:00
@susnux susnux force-pushed the fix/folder-tree branch 2 times, most recently from e9cad2a to 83b5608 Compare February 5, 2026 22:06
@susnux susnux requested a review from artonge February 5, 2026 22:06
@susnux susnux force-pushed the chore/update-files branch 2 times, most recently from 6b911e3 to e3068bf Compare February 6, 2026 10:46
Base automatically changed from chore/update-files to master February 6, 2026 11:42
@susnux susnux marked this pull request as ready for review February 6, 2026 11:42
@susnux susnux requested review from a team and skjnldsv as code owners February 6, 2026 11:42
@susnux susnux requested review from sorbaugh and removed request for a team February 6, 2026 11:42
@artonge

This comment was marked as resolved.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux

This comment was marked as resolved.

@artonge
Copy link
Contributor

artonge commented Feb 6, 2026

I was able to test:

  1. When loading from a subfolder, then there is no way to navigate the siblings, up to the root folder. There might not be an easy fix for that one. And I don't think this is new, so you can ignore.
  2. When loading from the root folder, it does depth 2 requests on all the folders of the root folder. We should do no request, until the tree view is open, and then only one depth 2 on the root folder when the tree view gets opened.
  3. Also, the views still seems to be registered, even though they are not visible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants